Skip to content

fix location of variable when function definition {v => ...} is enc… #5949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2023
Merged

fix location of variable when function definition {v => ...} is enc… #5949

merged 1 commit into from
Jan 21, 2023

Conversation

cristianoc
Copy link
Collaborator

@cristianoc cristianoc commented Jan 21, 2023 •
edited
Loading

…losed in braces

In addition to creating problems with the analysis performed by the editor integration, this was not issuing a warning for unused variable:

let _ = {thisGetsBrokenLoc => 4}

@cristianoc
fix location of variable when function definition {v => ...} is enc…
f84fa22 
…losed in braces

In addition to creating problems with the analysis performed by the editor integration, this was not issue a warning for unused variable:

```res
let _ = {thisGetsBrokenLoc => 4}
```
@cristianoc cristianoc requested a review from zth January 21, 2023 13:13
@cristianoc cristianoc merged commit 8ab0c37 into master Jan 21, 2023
@cristianoc cristianoc deleted the loc_braced_fun branch January 21, 2023 13:31
@fhammerschmidt fhammerschmidt mentioned this pull request Oct 2, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zth zth zth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cristianoc @zth